Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix copy-bulk.sh and optimise dependencies #42

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Fix copy-bulk.sh and optimise dependencies #42

merged 3 commits into from
Dec 6, 2023

Conversation

Silic0nS0ldier
Copy link
Contributor

@Silic0nS0ldier Silic0nS0ldier commented Dec 5, 2023 •
edited
Loading

Fixes shell usage and optimises dependency logic (gains will be more noticeable with bazelbuild/bazel#20434).

christianscott
christianscott requested changes Dec 5, 2023
View reviewed changes
Copy link
Member

@christianscott christianscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to remove pipefail?

internal/npm_install/bulk_copy.sh Outdated Show resolved Hide resolved
@Silic0nS0ldier
Copy link
Contributor Author

Why do we need to remove pipefail?

Because I wrote the script to use sh (POSIX shell) which does not support that option.

The suggestion of outright using bash would make it safe though.

@Silic0nS0ldier Silic0nS0ldier changed the title Remove pipefail bashism from POSIX shell script Fix copy-bulk.sh and optimise dependencies Dec 6, 2023
christianscott
christianscott approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@christianscott christianscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Silic0nS0ldier Silic0nS0ldier merged commit 4af5b4b into main Dec 6, 2023
@Silic0nS0ldier Silic0nS0ldier deleted the jordan-mele_optimise-copying-fix-bashism branch December 6, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianscott christianscott christianscott approved these changes

@jesses-canva jesses-canva Awaiting requested review from jesses-canva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Silic0nS0ldier @christianscott